Draft: Scoped custom elements registries #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
reviewed
Aug 20, 2020
source
Outdated
| @@ -66141,6 +66142,36 @@ dictionary <dfn>ElementDefinitionOptions</dfn> { | |||
| <span>connected</span>.</dd> | |||
| </dl> | |||
|
|
|||
| <p>New instances of <code>CustomElementRegistry</code> can be defined and attached to a | |||
| <span>ShadowRoot</span> through the registry option from <code | |||
| data-x="dom-Element-attachShadow">attachShadow()</code>. Those instances are are independent of | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
caridy
reviewed
Aug 20, 2020
source
Outdated
|
|
||
| <dd>Defines a new <span data-x="dom-CustomElementRegistry">Registry</span> that can map an | ||
| independent set of <span data-x="dom-window-customElements">custom elements</span>, which is | ||
| not attached yet to any <span>Document</span> or any <span>ShadowRoot</span>.</dd> |
There was a problem hiding this comment.
I believe custom registries can only be associated to a shadow root instance, not to a document.
also, I will like to use the the word "association" rather than "attach", because that opens the door to change that association at any given time.
leobalter
force-pushed
the
scoped-custom-elements-registries
branch
from
bae7b7a
to
b82f148
Compare
mfreed7
reviewed
Oct 16, 2020
leobalter
force-pushed
the
scoped-custom-elements-registries
branch
from
b82f148
to
9cb3afc
Compare
leobalter
force-pushed
the
scoped-custom-elements-registries
branch
from
e2c3553
to
e069979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See WHATWG Working Mode: Changes for more details.)